Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt for renamed customStorage #465

Closed
Ornias1993 opened this issue May 10, 2021 · 6 comments · Fixed by #477
Closed

Adapt for renamed customStorage #465

Ornias1993 opened this issue May 10, 2021 · 6 comments · Fixed by #477
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Ornias1993
Copy link
Member

Is your feature request related to a problem? Please describe.
Common 4.0.0 renamed customStorage to hostPathMounts (which is technically more correct)

Describe the solution you'd like
Adapt current charts and docs to reflect this change
@Ornias1993 Ornias1993 added the enhancement New feature or request label May 10, 2021
@Ornias1993 Ornias1993 changed the title Adapt docs for renamed customStorage Adapt for renamed customStorage May 10, 2021
@Ornias1993 Ornias1993 added documentation Improvements or additions to documentation good first issue labels May 10, 2021
@warllo54
Copy link
Contributor

warllo54 commented May 12, 2021 •
edited

@Ornias1993 Is this as simple as updating the docs and changing any "customStorage:" key to hostPathMounts for all apps?

@Ornias1993
Copy link
Member Author

@warllo54 Yes. :)
If you want to do it, feel completely free, i'll put it into a stagingbranch 👍

@warllo54
Copy link
Contributor

@Ornias1993 I'll certainly take a stab at this.

@warllo54
Copy link
Contributor

@Ornias1993 Do we want to change the lables in questions.yaml as shown below?

label: "Custom app storage" label: "Custom Storage"

label: "Hostpath app storage" label: "Hostpath Storage"

@Ornias1993
Copy link
Member Author

Yeah lets do that :)

I'm opting to slowly add more features to the Apps, so moving a little closer to using the same words in the GUI for things as we do in the charts, might be prefered :)

@Ornias1993 Ornias1993 mentioned this issue May 23, 2021
Merged
10 tasks
@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Apps for Common 4.*
3 participants
@Ornias1993 @warllo54 @truecharts-admin