Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(valheim): fix STATUS_HTTP variable label #4771

Merged
merged 2 commits into from Nov 23, 2022

Conversation

opello
Copy link
Contributor

@opello opello commented Nov 23, 2022

Description
Fix a copy and paste error where there were multiple SERVER_PUBLIC checkboxes when one was really STATUS_HTTP.

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?
This was a straightforward change that I did not test in any way.

📃 Notes:
None.

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Fix a copy and paste error where there were multiple SERVER_PUBLIC
checkboxes when one was really STATUS_HTTP.
Increment the minor version to pick up the variable fix in
5ab461b.
@truecharts-admin truecharts-admin added the size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2022
@opello opello changed the title Fix valheim Fix valheim STATUS_HTTP variable label Nov 23, 2022
@stavros-k
Copy link
Member

@all-contributors please add @opello for code

@allcontributors
Copy link
Contributor

@stavros-k

I've put up a pull request to add @opello! 🎉

@stavros-k stavros-k changed the title Fix valheim STATUS_HTTP variable label fix(valheim): fix STATUS_HTTP variable label Nov 23, 2022
@stavros-k stavros-k merged commit 7b64cf6 into truecharts:master Nov 23, 2022
@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Nov 23, 2022
@opello opello deleted the fix-valheim branch November 23, 2022 09:35
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/XS Categorises a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants