Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefly III #52

Closed
PackElend opened this issue Feb 2, 2021 · 14 comments · Fixed by #421
Closed

Add Firefly III #52

PackElend opened this issue Feb 2, 2021 · 14 comments · Fixed by #421
Assignees

Comments

@PackElend
Copy link

I would like to suggest https://www.firefly-iii.org
Install:
https://docs.firefly-iii.org/firefly-iii/installation/docker/
https://docs.firefly-iii.org/firefly-iii/installation/k8n/

The third-party helper apps consist only of single Docker containers, so the existing tool can be used.

@PackElend PackElend added the bug Something isn't working label Feb 2, 2021
@Ornias1993 Ornias1993 added New App Request and removed bug Something isn't working labels Feb 2, 2021
@warllo54
Copy link
Contributor

@Ornias1993 If I felt compelled to work on bringing this app to true charts are there any guidelines on how the helm chart should be structured? Are there any common charts like k8s-at-home that would be required?

@Ornias1993
Copy link
Member

@warllo54 the common chart AND a lot of other requirements apply.
Sadly enough i'm not in the position to write all of them down at.

That being said: If you can't figure it out with copy-pasta and trail-and-error, like the people before you, you might not be up to the task at all... It's not that hard to figure out ;-)

@Ornias1993
Copy link
Member

I've not seen any activity on this. Hence i'm going to assume @warllo54 stopped working on this :(

@warllo54
Copy link
Contributor

warllo54 commented Apr 7, 2021

@Ornias1993 I've been unusually busy with work as of late. I'm still hoping to get this going but I will probably wait until scale/true chart's initial development is done to prevent having to make significant changes right away. Also, I think waiting for the "DB Edition" of true charts might be wise. Feel free to leave this as No_Maintainer for the time being in case someone with more urgency wants to get this going asap.

@Ornias1993
Copy link
Member

Ornias1993 commented Apr 7, 2021

@warllo54
Thanks for your response!

I think you are confusing some things:

  • The initial design for SCALE Apps is done for a while now. No major formatting changes are expected

  • But TrueCharts will always be something that is under continued agile development. There won't be a formal "Release" version nor is it currently in "Alpha".

  • We did have a big refactor (available in the staging branch), but that is mostly limited to docs, structure and the common chart. individual App maintainers are not expected to implement the consequences of common-chart or structure refactors themselves, just review the changes done by others.

  • The primary reason the staging branch isn't merged into master, is actually a very stupid one:
    Currently the TrueNAS SCALE Middleware complains when you use the github designated "docs" folder :P

We do however, now have actual documentations about how apps needs to be structured, so at least we answered your original question :)

About databases:
All Requested Apps requiring databases have been flagged as "unblocked" because the draft for postgresql databases is already available and useable.

"DB Edition" is mostly just a milestone date, when we aim to have a significant amount of databases and/or database consuming Apps integrated. In that regard it's prefered to work on these Apps before rather than after the release of that milestone, as it enables the DB developers (which I assume would be mostly me) getting enough feedback and crush bugs before the milestone.

That being said:
In the end, you decide when you work on and what to work on. :)

@warllo54
Copy link
Contributor

warllo54 commented Apr 7, 2021

@Ornias1993 Thanks for your very detailed response which did indeed clear up some confusion. This is a very cool project and I hope to have the time to contribute to it.

@Ornias1993
Copy link
Member

Ornias1993 commented Apr 7, 2021

@warllo54 Thanks for the feedback, I think we should indeed've been a bit more clear with what the staging branch and versions represent... But as it's almost merged now, it should be fine... mostly :)

That being said: All effort and support is truely appreciated! :)
I cannot maintain all Apps by myself ^^

@warllo54
Copy link
Contributor

warllo54 commented May 1, 2021

@Ornias1993 I'm looking at getting started on a pr for this but I'm just not grasping how in the Bitwarden example the bitwarden container knows how to connect to the postgres data base. For fireflyiii they are set using the env variables listed below. Would you be able to list which lines of code in the Bitwarden app that ties the Bitwarden container to the postgres container ? It would be very helpful to learn how the heck this works. Sorry my lack of helm/kubernets knowledge is really showing here.

-e DB_HOST=CHANGEME \ -e DB_PORT=3306 \ -e DB_CONNECTION=mysql \ -e DB_DATABASE=CHANGEME \ -e DB_USERNAME=CHANGEME \ -e DB_PASSWORD=CHANGEME

@Ornias1993
Copy link
Member

check the env-tpl's and the secret (second from the top).
Bitwarden (annoyingly) wants a complete database url.

You should be fine to:

  • leaving the db url in the secret alone
  • set fixed DB_HOST (to match postgresql hostnameOverride)
  • set fixed DB_DATABASE
  • set fixes DB_USERNAME
  • Grab DB_PASSWORD from secret.

@Ornias1993
Copy link
Member

Ornias1993 commented May 1, 2021

Try something like this:

  • Copy the second secret.

  • Below "url" add:

  postgresql_host: {{ printf "%v-%v".Release.Name "postgresql" }}
  • Then inside values.yaml do this:
env:
  DB_USERNAME: firefly
  DB_DATABASE: firefly 

envValueFrom:
  DB_HOST:
    secretKeyRef:
      name: dbcreds
      key: postgresql_host
  DB_PASSWORD:
    secretKeyRef:
      name: dbcreds
      key: postgresql-password

@Ornias1993
Copy link
Member

Thats all i'm going to give, otherwise it would be faster for me to completely write it myself ;-)

@warllo54
Copy link
Contributor

warllo54 commented May 1, 2021

Thanks a bunch! Can’t wait to take a stab at this.

@Ornias1993
Copy link
Member

@warllo54 Awesome, I'll put you on the assignment list just to be clear to everyone involved :)
Thanks for your amazing drive/work ^^

@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants