Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stable): bump common on the 222 #7927

Merged
merged 5 commits into from Apr 11, 2023
Merged

fix(stable): bump common on the 222 #7927

merged 5 commits into from Apr 11, 2023

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Apr 11, 2023

Description
There where some things not correctly setup in common.
This bumps common on the 222 stable charts ported to new common, to ensure things list persistence list keep working.

Fixes: #7924

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@Ornias1993 Ornias1993 requested a review from a team as a code owner April 11, 2023 16:59
@truecharts-admin truecharts-admin added the size/XL Categorises a PR that changes 500-999 lines, ignoring generated files. label Apr 11, 2023
@Ornias1993 Ornias1993 changed the title fix(stabl): bump common on the 222 fix(stable): bump common on the 222 Apr 11, 2023
@truecharts-admin truecharts-admin added the precommit:ok CI status: pre-commit validation successful label Apr 11, 2023
@Ornias1993 Ornias1993 merged commit 9ec6cd6 into master Apr 11, 2023
6 checks passed
@Ornias1993 Ornias1993 deleted the 222common1 branch April 11, 2023 18:00
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
precommit:ok CI status: pre-commit validation successful size/XL Categorises a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional mountpoints not working
2 participants