Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(stable): BREAKING CHANGE migrate to new common part 2 #7992

Merged
merged 1 commit into from Apr 14, 2023

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Apr 14, 2023

Description
See: #7900

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@truecharts-admin truecharts-admin added size/XXL Categorises a PR that changes 1000+ lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful labels Apr 14, 2023
@Ornias1993 Ornias1993 marked this pull request as ready for review April 14, 2023 15:57
@Ornias1993 Ornias1993 requested a review from a team as a code owner April 14, 2023 15:57
@Ornias1993 Ornias1993 merged commit 278904b into master Apr 14, 2023
72 checks passed
@Ornias1993 Ornias1993 deleted the port/stable2b branch April 14, 2023 16:11
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
precommit:ok CI status: pre-commit validation successful size/XXL Categorises a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants