Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps): fix various issues #8095

Merged
merged 11 commits into from Apr 19, 2023
Merged

fix(apps): fix various issues #8095

merged 11 commits into from Apr 19, 2023

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Apr 19, 2023

Description

⚒️ Fixes #8092
⚒️ Fixes #8076
⚒️ Fixes #8070
⚒️ Fixes #7970
⚒️ Fixes #7977

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@truecharts-admin truecharts-admin added the size/S Categorises a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2023
@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Apr 19, 2023
@truecharts-admin truecharts-admin added size/M Categorises a PR that changes 30-99 lines, ignoring generated files. and removed size/S Categorises a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2023
@truecharts-admin truecharts-admin added size/L Categorises a PR that changes 100-499 lines, ignoring generated files. and removed size/M Categorises a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2023
@truecharts-admin truecharts-admin added precommit:failed CI status: pre-commit validation failed and removed precommit:ok CI status: pre-commit validation successful install:ok CI status: install successful labels Apr 19, 2023
@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful and removed precommit:failed CI status: pre-commit validation failed labels Apr 19, 2023
@stavros-k stavros-k marked this pull request as ready for review April 19, 2023 22:40
@stavros-k stavros-k requested review from a team and Ornias1993 as code owners April 19, 2023 22:40
@stavros-k stavros-k merged commit 3fb86ba into master Apr 19, 2023
48 of 49 checks passed
@stavros-k stavros-k deleted the fixes branch April 19, 2023 23:19
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/L Categorises a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
2 participants