Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vikunja): remove additional_attrs from list #8880

Merged
merged 1 commit into from May 10, 2023
Merged

fix(vikunja): remove additional_attrs from list #8880

merged 1 commit into from May 10, 2023

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented May 9, 2023

Description

⚒️ Fixes #8870

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@stavros-k stavros-k marked this pull request as ready for review May 9, 2023 19:32
@truecharts-admin truecharts-admin added the size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. label May 9, 2023
@stavros-k stavros-k requested review from a team and Ornias1993 as code owners May 9, 2023 19:32
@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels May 9, 2023
@stavros-k stavros-k merged commit ce0baae into master May 10, 2023
37 checks passed
@stavros-k stavros-k deleted the vikfix branch May 10, 2023 06:29
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/XS Categorises a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vikunja won't install (Unexpected keyword arguments: 'additional_attrs')
2 participants