Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stable): Add Global Pod Options #9007

Merged
merged 35 commits into from May 22, 2023
Merged

feat(Stable): Add Global Pod Options #9007

merged 35 commits into from May 22, 2023

Conversation

StevenMcElligott
Copy link
Member

Description

Figured I'll manually add them to the initial batch of ported charts to the new common that are missing the option
⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Copy link
Member

@Ornias1993 Ornias1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change this:

# Include{serviceExpertRoot}
            default: false

to this:

# Include{serviceExpertRoot}

while at it and put it in a single PR?

@StevenMcElligott StevenMcElligott changed the title feat(Stable): Add Global Pod Options A-B feat(Stable): Add Global Pod Options A-D May 20, 2023
@StevenMcElligott StevenMcElligott marked this pull request as ready for review May 20, 2023 18:42
@StevenMcElligott StevenMcElligott requested a review from a team as a code owner May 20, 2023 18:42
@StevenMcElligott StevenMcElligott marked this pull request as draft May 21, 2023 12:36
@StevenMcElligott StevenMcElligott changed the title feat(Stable): Add Global Pod Options A-D [DMN] feat(Stable): Add Global Pod Options A-O May 21, 2023
@StevenMcElligott StevenMcElligott changed the title [DMN] feat(Stable): Add Global Pod Options A-O [DMN] feat(Stable): Add Global Pod Options A-R May 21, 2023
StevenMcElligott and others added 8 commits May 21, 2023 10:31
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
@StevenMcElligott StevenMcElligott marked this pull request as ready for review May 21, 2023 15:59
@StevenMcElligott StevenMcElligott changed the title [DMN] feat(Stable): Add Global Pod Options A-R feat(Stable): Add Global Pod Options May 21, 2023
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
@Ornias1993
Copy link
Member

Should start passing catalog tests now :)

@StevenMcElligott
Copy link
Member Author

@Ornias1993 catalog passed we're in business

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
@Ornias1993 Ornias1993 merged commit 001551b into truecharts:master May 22, 2023
5 checks passed
@StevenMcElligott StevenMcElligott deleted the podoptions branch May 22, 2023 15:34
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants