New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Stable): Add Global Pod Options #9007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change this:
# Include{serviceExpertRoot}
default: false
to this:
# Include{serviceExpertRoot}
while at it and put it in a single PR?
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Merge E-J into A-D
Add up to O
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Should start passing catalog tests now :) |
@Ornias1993 catalog passed we're in business |
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this |
Description
Figured I'll manually add them to the initial batch of ported charts to the new common that are missing the option
⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.png
Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.