Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unifi] GUI - Additional settings for optional services are shown even when disabled. #939

Closed
joachimbaten opened this issue Sep 9, 2021 · 3 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@joachimbaten
Copy link
Contributor

Describe the bug
For both the 'SpeedTest' and 'Guest Portal Service' all the settings are visible even if the service is disabled.

To Reproduce
Steps to reproduce the behavior:

  1. Install the unifi app and enble/disable the SpeedTest and/or GuestPortal service.
  2. Detailed options are always visible

Expected behavior
When the service is not enabled, the specific options should not be shown in the GUI

@joachimbaten joachimbaten added the bug Something isn't working label Sep 9, 2021
@joachimbaten joachimbaten self-assigned this Sep 9, 2021
@Ornias1993
Copy link
Member

Yes, thats on purpose.
Earlier on with SCALE hiding things was super tricky with lists and such.

I'll look into if we can do it by now, but this is more of a general feature request and not limited to Unifi.
PR's for it to just unifi will hence be denied anyway, because it makes apps unmaintainable to diverge these settings this much.

@Ornias1993
Copy link
Member

@joachimbaten Won't fix, cannot be done.

@Ornias1993 Ornias1993 added the wontfix This will not be worked on label Sep 12, 2021
@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants