Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Are configurable timeouts specified on seconds or milliseconds? #103

Closed
4 tasks done
wikiti opened this issue Nov 13, 2020 · 2 comments · Fixed by #104
Closed
4 tasks done

[QUESTION] Are configurable timeouts specified on seconds or milliseconds? #103

wikiti opened this issue Nov 13, 2020 · 2 comments · Fixed by #104
Assignees

Comments

@wikiti
Copy link
Contributor

wikiti commented Nov 13, 2020

New Issue Checklist

Issue Description

The documentation states the following for connection_timeout and response_timeout configuration options:

Optional parameter. Connection timeout is equal to 2 ms by default.
Optional parameter. A SMTP server response timeout is equal to 2 ms by default.

I understand that timeouts are specified in milliseconds. However, after taking a look at the source code, it seems to me that Timeout.timeout is used to handle timeouts, which uses seconds.

Is the documentation wrong, or should timeouts be handled on milliseconds rather than seconds?

Complete output when running truemail, including the stack trace and command used
[INSERT OUTPUT HERE]
@bestwebua
Copy link
Member

Hola, @wikiti! First of all I want to say thank you for your report. You're absolutely right! In point of fact Timeout.timeout, Net::SMTP#open_timeout, Net::SMTP#read_timeout use seconds, so Truemail uses seconds too. And this time there're wrong time units for configuration timeouts in readme and project docs. I will fix it today.

@bestwebua
Copy link
Member

Fixed in readme and docs.

@bestwebua bestwebua linked a pull request Nov 15, 2020 that will close this issue
5 tasks
@bestwebua bestwebua changed the title Are configurable timeouts specified on seconds or milliseconds? [QUESTION] Are configurable timeouts specified on seconds or milliseconds? Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants