Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Remove state tree manipulations that cause race condition #234

Closed
aakilfernandes opened this issue Dec 31, 2016 · 2 comments
Closed

Remove state tree manipulations that cause race condition #234

aakilfernandes opened this issue Dec 31, 2016 · 2 comments

Comments

@aakilfernandes
Copy link
Contributor

https://github.com/ethereumjs/testrpc/blob/master/lib/blockchain_double.js#L405-L409
https://github.com/ethereumjs/testrpc/blob/master/lib/blockchain_double.js#L448-L452
https://github.com/ethereumjs/testrpc/blob/master/lib/blockchain_double.js#L486-L490

By temporarily mapulating the stateTrie root, the blockchain will return false values until it is reverted (when the callback excutes)

I'm working on a fix to the Trie class to allow passing in a custom root, which should solve this

@benjamincburns
Copy link
Contributor

Bear in mind that it's my first day on the job, but I think we could sidestep this by making processing of simultaneous requests share fewer resources, including especially the VM, provided this doesn't require significant memory/CPU overhead.

@mikeseese
Copy link
Contributor

We're now tracking this in #453

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants