Merge branch 'beta' into develop

.travis.yml

@@ -1,8 +1,18 @@
+version: ~> 1.0
 language: node_js
 node_js:
   - "8"
   - "10"
   - "12"
+os:
+  - linux
+  - osx
+  - windows
+# using xcode9.2 forces osx 10.12, which is WAAAYYYYYY faster than 10.13
+# in fact, we couldn't get osx 10.13 to ever finish the running the tests
+osx_image: xcode9.2
+git:
+  autocrlf: false
 
 addons:
   apt:
@@ -19,11 +29,6 @@ before_install:
       export LINK="gcc-5";
       export LINKXX="g++-5";
     fi
-  - nvm --version
-  - node --version
-  - npm --version
-  - gcc --version
-  - g++ --version
 
 after_success:
   npm run coverage

lib/database/filedown.js

@@ -52,26 +52,46 @@ FileDown.prototype._put = function(key, value, options, callback) {
   // leveldb implementation that doesn't use a separate file for every key Soon(TM).
   accessQueue.execute(lKey, () => {
     // get a tmp file to write the contents to...
-    tmp.file((err, path, fd) => {
+    tmp.file((err, path, fd, cleanupTmpFile) => {
       if (err) {
         callback(err);
         accessQueue.next(lKey);
         return;
       }
 
-      // write the contents to that temp file
+      // write the value to our temporary file
       fs.writeFile(fd, value, "utf8", (err) => {
         if (err) {
+          cleanupTmpFile();
           callback(err);
           accessQueue.next(lKey);
           return;
         }
-        // move the temp file to its final destination
+
+        // It worked! Move the temporary file to its final destination
         fs.rename(path, lKey, (err) => {
-          callback(err);
+          if (err) {
+            cleanupTmpFile();
+            callback(err);
+            accessQueue.next(lKey);
+            return;
+          }
 
-          // if there is more work to be done on this key, do it.
-          accessQueue.next(lKey);
+          // make sure we close this file descriptor now that the file is no
+          // longer "temporary" (because we successfully moved it)
+          fs.close(fd, (err) => {
+            if (err) {
+              // at this point things seem to have worked, but juuuussttt in
+              // case `fs.close` fails, let's log some info so we can try to
+              // debug it
+              console.warn("An unexpected file descriptor close error occured: ", err);
+              cleanupTmpFile();
+            }
+            callback();
+
+            // if there is more work to be done on this key, do it.
+            accessQueue.next(lKey);
+          });
         });
       });
     });