This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
perf: cache requests to the underlying fork provider #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjpaterno
approved these changes
Jun 17, 2020
lib/utils/forkedblockchain.js
Outdated
| this.forkBlockNumber = options.fork_block_number; | ||
| this.forkCacheSize = parseInt(options.fork_cache_size == null ? 10000 : options.fork_cache_size); |
There was a problem hiding this comment.
Should we default to 10000? I wonder if this should be opt in, though I don't suspect this will interfere with any current tests.
test/forking.js
Outdated
| provider.send(tx, (_, result) => { | ||
| const result2 = Object.assign({}, result, { id: null }); | ||
| assert.deepStrictEqual(result2, result1); | ||
| assert.strictEqual(callCount, 1, "cache didn't work"); |
davidmurdoch
force-pushed
the
fubhy-develop
branch
from
e8042ce
to
97d5711
Compare
davidmurdoch
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #581