This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
test: throw if test contracts fail compilation #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
force-pushed
the
fix/throw-if-test-contract-fails-compilation
branch
from
843e190
to
b728200
Compare
davidmurdoch
approved these changes
Sep 23, 2020
|
Looks like CI is failing. Will merge if we can get some green 🙂 |
|
alright tests are passing @davidmurdoch |
davidmurdoch
changed the title
davidmurdoch
deleted the
fix/throw-if-test-contract-fails-compilation
branch
1 task
This was referenced Jun 6, 2021
This was referenced Jun 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a simple improvement that will throw if the test contracts fail compilation. Otherwise, the error gets squashed and you'll get some other " of undefined" error at line 44 when you try to read
result.contracts.