Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Ensure we stable-sort transactions in the tx pool #1193

Closed
davidmurdoch opened this issue Sep 17, 2021 · 1 comment
Closed

Ensure we stable-sort transactions in the tx pool #1193

davidmurdoch opened this issue Sep 17, 2021 · 1 comment
Milestone

Comments

@davidmurdoch
Copy link
Member

davidmurdoch commented Sep 17, 2021

If two identical transactions are in the pool it may be possible to switch the order in which they are "mined" depending on how many times the pool is sorted.

We may need to sort by a secondary key, the from address may work without adding any additional properties to the transaction -- though this would bias transaction ordering based on the address' lexicographic sort order -- unless we hash the address first, which seems like unnecessary extra work ... or we could used an FIFO-based sort index for this.

@davidmurdoch davidmurdoch added this to the 7.0.0 milestone Sep 17, 2021
@davidmurdoch
Copy link
Member Author

closing in favor of #1104

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant