Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Disconnecting EthereumProvider doesn't wait for currently executing tasks #3499

Open
jeffsmale90 opened this issue Aug 4, 2022 · 0 comments
Open

Disconnecting EthereumProvider doesn't wait for currently executing tasks #3499

jeffsmale90 opened this issue Aug 4, 2022 · 0 comments
Assignees
@jeffsmale90

Comments

@jeffsmale90
Copy link
Contributor

jeffsmale90 commented Aug 4, 2022 •
edited

When calling EthereumProvider.disconnect() we don't wait for inflight tasks to complete. This means that:

  • pending tasks are rejected (in order), before currently executing tasks are completed.
  • current executing tasks can reject with an internal error (e.g. "Data not open")

Ideally, we would complete currently executing tasks before shutting down the blockchain, and rejecting pending tasks.

See #3433
@jeffsmale90 jeffsmale90 changed the title Disconnecting EthereumProvider doesn't respect FIFO nature of work queue Disconnecting EthereumProvider doesn't shutdown especially cleanly Aug 4, 2022
@jeffsmale90 jeffsmale90 changed the title Disconnecting EthereumProvider doesn't shutdown especially cleanly Disconnecting EthereumProvider doesn't wait for currently executing tasks Aug 4, 2022
@jeffsmale90 jeffsmale90 mentioned this issue Aug 5, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffsmale90 jeffsmale90

Labels
None yet
Projects
Ganache
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffsmale90