Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

System Error when sending batch request with 1 not valid item #402

Closed
Shpionus opened this issue Apr 3, 2019 · 3 comments
Closed

System Error when sending batch request with 1 not valid item #402

Shpionus opened this issue Apr 3, 2019 · 3 comments

Comments

@Shpionus
Copy link

Shpionus commented Apr 3, 2019

System Error when running Ganache 2.0.0 on linux

PLATFORM: linux
GANACHE VERSION: 2.0.0
GANASHE COMMIT: 16f44f84370798a33710f8569be0fe829cddc216

Request:

Send wrong parameter for the second request: pendi3ng instead of pending.

[{
	"jsonrpc":"2.0",
	"method":"eth_getBlockByNumber",
	"params":["latest", true],
	"id":1
}, {
	"jsonrpc":"2.0",
	"method":"eth_getBlockByNumber",
	"params":["pendi3ng", true],
	"id":2
}]

EXCEPTION:

TypeError: Cannot read property 'error' of undefined
    at Provider.cleanUpErrorObject (/node_modules/ganache-core/lib/provider.js:186:24)
    at Provider.reportErrorInResponse (/node_modules/ganache-core/lib/provider.js:259:15)
    at Object.intermediary [as callback] (/node_modules/ganache-core/lib/provider.js:100:28)
    at self.engine.sendAsync (/node_modules/ganache-core/lib/provider.js:169:12)
    at /node_modules/ganache-core/node_modules/async/internal/map.js:32:9
    at /node_modules/ganache-core/node_modules/async/internal/once.js:12:16
    at iteratorCallback (/node_modules/ganache-core/node_modules/async/eachOf.js:58:13)
    at /node_modules/ganache-core/node_modules/async/internal/onlyOnce.js:12:16
    at /node_modules/ganache-core/node_modules/async/internal/map.js:29:13
    at /node_modules/ganache-core/node_modules/web3-provider-engine/index.js:150:9
    at /node_modules/ganache-core/node_modules/async/internal/once.js:12:16
    at replenish (/node_modules/ganache-core/node_modules/async/internal/eachOfLimit.js:61:25)
    at /node_modules/ganache-core/node_modules/async/internal/eachOfLimit.js:71:9
    at eachLimit (/node_modules/ganache-core/node_modules/async/eachLimit.js:43:36)
    at /node_modules/ganache-core/node_modules/async/internal/doLimit.js:9:16
    at end (/node_modules/ganache-core/node_modules/web3-provider-engine/index.js:127:5)
    at /node_modules/ganache-core/lib/subproviders/geth_api_double.js:178:16
    at _combinedTickCallback (internal/process/next_tick.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

APPLICATION LOG:

T+0ms: Starting server (version 2.0.0) with initial configuration: {"gasLimit":6721975,"gasPrice":20000000000,"hardfork":"petersburg","hostname":"127.0.0.1","port":7545,"network_id":5777,"default_balance_ether":100,"total_accounts":10,"unlocked_accounts":[],"locked":false,"vmErrorsOnRPCResponse":true,"verbose":false,"db_path":"/home/ivan/.config/Electron/workspaces/LiquineqMultiassetToken/chaindata"}
T+442ms: Ganache started successfully!
T+442ms: Waiting for requests...
T+484ms: eth_getCode
T+524ms: eth_subscribe
T+567ms: eth_getLogs
T+567ms: eth_subscribe
T+608ms: eth_getCode
T+651ms: eth_getCode
T+12048ms: eth_getBlockByNumber
T+12120ms: eth_getBlockByNumber
T+12188ms: eth_getBlockByNumber
T+12696ms: eth_getBlockByNumber
T+17704ms: eth_getBlockByNumber
T+22713ms: eth_getBlockByNumber
T+27721ms: eth_getBlockByNumber
T+32727ms: eth_getBlockByNumber
T+37736ms: eth_getBlockByNumber
T+42744ms: eth_getBlockByNumber
T+47752ms: eth_getBlockByNumber
T+52762ms: eth_getBlockByNumber
T+57768ms: eth_getBlockByNumber
T+57987ms: eth_getBlockByNumber
T+57987ms: eth_getBlockByNumber
T+58145ms: eth_unsubscribe
T+58214ms: eth_unsubscribe
T+58275ms: eth_unsubscribe
T+58275ms: eth_unsubscribe
T+58345ms: eth_unsubscribe
@davidmurdoch davidmurdoch transferred this issue from trufflesuite/ganache-ui Apr 3, 2019
@davidmurdoch
Copy link
Member

@Shpionus, interesting bug! Thanks for opening the issue. This should be an easy fix. I'm in the middle of a release now and will work on getting a fixed shipped in the next release.

@gnidan
Copy link
Contributor

gnidan commented Feb 24, 2021

Ganache v7 is reportedly much harder to crash (according to @davidmurdoch); batching in particular has been revisited. Keeping this open to verify once v7 is out the door.

@gnidan gnidan modified the milestones: 7.0.0, 7.1.0 Feb 24, 2021
@davidmurdoch
Copy link
Member

Closing as I've confirmed that this has been fixed in v7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants