Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Investigate if the genesis block created when forking is neccessary. #341

Closed
davidmurdoch opened this issue Feb 26, 2019 · 1 comment
Closed

Comments

@davidmurdoch
Copy link
Member

The goal is to ensure that the first block mined after initializing a forking provider with a fork_block_number is fork_block_number + 1, not fork_block_number + 2 as it is now.

Something to keep in mind here is that we need need to be able to store the initial accounts and if we don't create an initial block where does this data get stored?

If it does still work in memory will it work with a persisted DB? This question is possibly blocked by: #340, if the tests there prove that this doesn't actually work.

@davidmurdoch davidmurdoch changed the title Investigate if the genesis block creating when forking is neccessary. Investigate if the genesis block created when forking is neccessary. Feb 28, 2019
@davidmurdoch davidmurdoch added this to the 3.0.0 milestone Oct 19, 2020
@davidmurdoch davidmurdoch self-assigned this Feb 11, 2021
@gnidan
Copy link
Contributor

gnidan commented Feb 24, 2021

@davidmurdoch reports that he is now smarter and that this is, in fact, necessary.

@gnidan gnidan closed this as completed Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants