Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Extra garbage logging left over while running migrations #4553

Closed
eggplantzzz opened this issue Dec 16, 2021 · 1 comment
Closed

Extra garbage logging left over while running migrations #4553

eggplantzzz opened this issue Dec 16, 2021 · 1 comment

Comments

@eggplantzzz
Copy link
Contributor

eggplantzzz commented Dec 16, 2021

When running migrations, there is some extra, unnecessary logging that gets left around in the terminal.
Screen Shot 2021-12-16 at 5 15 04 PM

The things to note in the screenshot are the extra "Blocks: 0...." and "Saving migration to chain." at the end. You can also see that there is a "Blocks: 0..." in the second line of data under the "Replacing 'MetaCoin'" section which I don't believe should be there.

This comes from the migrations logging, and more specifically from this bit of code and involves this method and maybe this method.

I'm also pretty sure that ora plays a role in this code getting left around as it doesn't really play well with other logs that get printed. You can often get some pretty weird, ugly results using this spinner package while logging other things. It might be just that the spinner is not stopped at the appropriate time during the logging of all this information or some other async nonsense that is not supposed to be occurring.

@dkillen
Copy link

dkillen commented Mar 3, 2022

Fixed in v5.5.1

@dkillen dkillen closed this as completed Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants