This repository has been archived by the owner on Apr 23, 2019. It is now read-only.
Remove android:allowBackup="true" #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow apps using the library to select their own backup option without needing to override it. Libraries should't use allowBackup in theeir manifest. This provokes a build error in recent versions of the Gradle plugin when the application sets this value to false. Temporary workaround is to add `tools:replace="android:allowBackup"` to the *application* tag in the app's manifest.
truizlop
added a commit
that referenced
this pull request
Oct 5, 2015
Remove android:allowBackup="true"
|
Thanks, my mistake, I forgot to remove it. |
|
Thank you ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow apps using the library to select their own backup option without needing to override it. Libraries should't use allowBackup in theeir manifest. This provokes a build error in recent versions of the Gradle plugin when the application sets the value to false.
Temporary workaround is to add
tools:replace="android:allowBackup"to the application tag in the app's manifest.I'm creating the pull request against master because I don't see there is any other branch for development.