Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Sass's multi-line comment syntax to docs #84

Closed
gvinter opened this issue Apr 29, 2014 · 11 comments
Closed

adding Sass's multi-line comment syntax to docs #84

gvinter opened this issue Apr 29, 2014 · 11 comments

Comments

@gvinter
Copy link

gvinter commented Apr 29, 2014

I imagine using Hologram in addition to my normal Compass or SassC compiling, not in place of it.

To do this without getting errors, you need to use Sass's multi-line comments "//". but the docs only have single line: "/*".

I'm sure future developers would appreciate that in the docs, it's a bit of a nuance.

@aflanagan aflanagan self-assigned this Apr 29, 2014
@marcysutton
Copy link

Are you sure you don't have that backwards? // creates a single line comment. /* */ is multi-line. http://sass-lang.com/documentation/file.SASS_REFERENCE.html#comments

@jdcantrell
Copy link
Contributor

Actually @gvinter is right, we only document the /* */ and need to document the other syntax when you use .sass vs .scss

Example: https://github.com/jdcantrell/gxl/blob/master/sass/_layout.sass

@aflanagan
Copy link
Contributor

I could have sworn it was already in the docs (that's why i closed the issue), but looking now I don't see it. Sorry about that.

@aflanagan
Copy link
Contributor

Added. 766d763

@jdcantrell
Copy link
Contributor

👏 👏 👏

👏 👏

@gvinter
Copy link
Author

gvinter commented Jun 24, 2014

Thanks!

@allypalanzi
Copy link

On this note, it would be nice if hologram supported // for single line comments so that when .scss files are compiled to .css they lose the comments.

@aflanagan
Copy link
Contributor

Yeah, we've discussed this before. My current position on it is that stripping the hologram comments should be the work of whatever build/minification tool you are using. That way we don't have to do too much fancy parsing of the comments in files.

@jdcantrell
Copy link
Contributor

I'm not sure this will work for your use case but you minify and strip all comments out with compass using:

compass compile --output-style=compressed

Or with plain sass:

sass --style compressed

@jamierytlewski
Copy link

I know this issue is closed and I've seen it brought up a couple of times, but what would be nice is to allow single-line comments for those that use linting programs and have setup for single line comments.

@jdcantrell
Copy link
Contributor

Hmm, what change are you looking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants