Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RDF serialisation, prov:atTime attribute #88

Closed
wants to merge 1 commit into from

Conversation

cmaumet
Copy link
Contributor

@cmaumet cmaumet commented Oct 12, 2016

Hi @satra, @trungdong,

This is a small fix to the RDF serialisation (cf. #49).

I think that the prov:time attribute in a Generation should be replaced by a prov:atTime attribute (cf. https://www.w3.org/TR/prov-o/#atTime). @satra: do you agree with this?

This issue was identified when testing the prov RDF serialisation as part of https://github.com/incf-nidash/nidmresults-fsl. Apart from this small issue and RDFLib/rdflib#655, everything looks fine to me!

@trungdong
Copy link
Owner

Unfortunately, this only applies to PROV-O. Other representations still use prov:time.

You would probably want to have a PROV-O specific constant instead of changing PROV_ATTR_TIME.

@satra
Copy link
Contributor

satra commented Oct 12, 2016

@cmaumet - i think we can take care of this in the rdf serialization. there are a few things that do this for other PROV-O concepts.

@cmaumet
Copy link
Contributor Author

cmaumet commented Oct 12, 2016

Yes, if I remember well prov:location/prov:atLocation is another one...

@satra
Copy link
Contributor

satra commented Oct 12, 2016

@cmaumet - the atLocation was taken care of, but not atTime - i'm running a separate set of tests now to ensure that these are all covered.

@cmaumet
Copy link
Contributor Author

cmaumet commented Oct 13, 2016

I am closing this PR as @satra has now fixed the issue in #90.

@cmaumet cmaumet closed this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants