Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Move assets from apps folder to libs/shared #36

Closed
nikosanif opened this issue Apr 6, 2021 · 1 comment · Fixed by #41
Closed

Suggestion: Move assets from apps folder to libs/shared #36

nikosanif opened this issue Apr 6, 2021 · 1 comment · Fixed by #41

Comments

@nikosanif
Copy link
Contributor

Awesome work!

I have a suggestion regarding the structure since you use Nx Workspace.
You could move the entire apps/angular-spotify/src/assets folder to a more generic library (e.g. libs/shared/assets).
Thus, you can use pathing to any folder within the project (apps & libs) and will have nicely architectured new lib only for assets.

P.S. I can help on this issue if you want.

@trungvose
Copy link
Owner

@nikosanif Cheers! I think having a shared lib asset is a truly a best practice. Feel free to refactor the code and create a new PR. I'll be happy to review it.

Notes: I am using lots of images for the repo README, please help to update there as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants