Relax key kind check in derive_key for hmacsha256 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably keep the check and add a |
In #38 [0], we restricted the operations for the hmacsha256 mechanism to symmetric and shared keys. This breaks fido-authenticator because it uses hmacsha256 derive_key on EC keys [1]. This patch relaxes the restrictions to allow all key kinds. [0] trussed-dev#38 [1] trussed-dev/fido-authenticator#21
robin-nitrokey
force-pushed
the
relax-key-kind
branch
from
6bfbe33
to
36ee8ff
Compare
|
Good point, done. |
sosthene-nitrokey
approved these changes
Dec 1, 2022
daringer
approved these changes
Dec 14, 2022
|
Philosophically, I think we could allow (or at least imagine) casting an asymmetric secret key to a "shared secret", which is always only used as input to a KDF kind of function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38 [0], we restricted the operations for the hmacsha256 mechanism to symmetric and shared keys. This breaks fido-authenticator because it uses hmacsha256 derive_key on EC keys [1]. This patch relaxes the restrictions to allow all key kinds.
[0] #38
[1] trussed-dev/fido-authenticator#21
cc @sosthene-nitrokey: I can’t add you as a reviewer, but please have a look.