Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] when ComboBox options prop is updated displayed options do not change #2182

Closed
yeonsy opened this issue Jul 29, 2022 · 2 comments · Fixed by #2715
Closed

[fix] when ComboBox options prop is updated displayed options do not change #2182

yeonsy opened this issue Jul 29, 2022 · 2 comments · Fixed by #2715
Assignees
@werdnanoslen
Labels
type: bug Something isn't working like it's supposed to

Comments

@yeonsy
Copy link

yeonsy commented Jul 29, 2022 •
edited

ReactUSWDS Version & USWDS Version:

react-uswds: 3.1.0
uswds: 2.13.3

Describe the bug

When ComboBox options prop is updated displayed options do not change

gif demonstrating issue

Seems like the component should watch for changes to the prop and dispatch an update options action

To Reproduce

See: https://github.com/yeonsy/bug-report/tree/main/react-uswds/combobox-options-update#readme

Expected behavior

Displayed options should be synced with options prop

Device and Browser Information (please complete the following information if describing a UI bug):

Firefox 102
@yeonsy yeonsy added the type: bug Something isn't working like it's supposed to label Jul 29, 2022
@fanwari1
Copy link

It has been a while since this was reported. Does anyone have any update on this? Even when you call an api to get data and then call a setter, it still doesn't work. It makes it very difficult to use this component.

@werdnanoslen werdnanoslen mentioned this issue Jan 19, 2024
Merged
@werdnanoslen werdnanoslen self-assigned this Jan 19, 2024
@werdnanoslen
Copy link
Member

werdnanoslen commented Jan 19, 2024 •
edited

Hi folks, this PR should resolve this ☝️

Jan-19-2024 10-59-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@werdnanoslen werdnanoslen

Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Added hook to combobox for when options change trussworks/react-uswds
3 participants
@werdnanoslen @fanwari1 @yeonsy