Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix USWDS.svg 404 in storybook #2846

Open
werdnanoslen opened this issue Mar 22, 2024 · 1 comment · May be fixed by #2847
Open

[build] Fix USWDS.svg 404 in storybook #2846

werdnanoslen opened this issue Mar 22, 2024 · 1 comment · May be fixed by #2847
Labels
good first infra issue Good for newcomers with infra and CI affinities good first issue Good for newcomers type: bug Something isn't working like it's supposed to

Comments

@werdnanoslen
Copy link
Member

ReactUSWDS Version & USWDS Version:

Current main, tag 9.0.0

Describe the bug

Some recent Vite/build changes seem to have resulted in the uswds.svg 404ing on the deployed storybook, though it shows locally.

To Reproduce
Steps to reproduce the behavior:

  1. Go to deployed storybook
  2. See there's no uswds svg logo in top-left corner
  3. See 404 in console

Expected behavior

Logo should show up

Screenshots

Observed, deployed:
Screenshot 2024-03-22 at 12 32 14 PM

Expected, locally:
Screenshot 2024-03-22 at 12 31 26 PM

Additional context

Device and Browser Information (please complete the following information if describing a UI bug):
@werdnanoslen werdnanoslen added type: bug Something isn't working like it's supposed to good first issue Good for newcomers good first infra issue Good for newcomers with infra and CI affinities labels Mar 22, 2024
@jpandersen87
Copy link
Contributor

Have a fix in #2847

@werdnanoslen werdnanoslen linked a pull request Mar 22, 2024 that will close this issue
ci: dangerfile and build-and-test updated #2847
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first infra issue Good for newcomers with infra and CI affinities good first issue Good for newcomers type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: dangerfile and build-and-test updated jpandersen87/react-uswds
2 participants
@werdnanoslen @jpandersen87