Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Storybook: odd styling for label with required marker #2866

Open
reggieriser opened this issue Apr 2, 2024 · 2 comments
Open

[docs] Storybook: odd styling for label with required marker #2866

reggieriser opened this issue Apr 2, 2024 · 2 comments
Labels
type: documentation Improvements or additions to documentation

Comments

@reggieriser
Copy link

Does this documentation relate to a specific USWDS feature?

Yes, see the styling of a Label with Required Marker.

Is your documentation related to a problem or inconsistency? Please describe.

The styling of the required marker shows some dots underneath which shouldn't be there:

Screenshot 2024-04-02 at 12 15 27 PM

Describe the documentation you'd like

Ensure the styling matches what USWDS shows for a required field.

Additional context

I think this is related to the fact that the label is not within the context of a form element with the usa-form class (there's actually no form at all). Perhaps this label and any other form fields could be rendered in Storybook within the context of a form with the proper class?

@reggieriser reggieriser added the type: documentation Improvements or additions to documentation label Apr 2, 2024
@crwallace
Copy link
Contributor

@reggieriser is this a documentation need or a bug fix related to styling? Just want to make sure I am understanding this correctly.

@reggieriser
Copy link
Author

@crwallace ... I would categorize it as more of a documentation fix (assuming we consider Storybook to be documentation). For more context, see this Slack thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants