Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printable representation of Attack objects [JATIC-I2-IBM] #2272

Closed
kieranfraser opened this issue Sep 6, 2023 · 0 comments · Fixed by #2274
Closed

Printable representation of Attack objects [JATIC-I2-IBM] #2272

kieranfraser opened this issue Sep 6, 2023 · 0 comments · Fixed by #2274
Assignees
Labels
enhancement New feature or request improvement Improve implementation
Projects
Milestone

Comments

@kieranfraser
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Printing any attack object (excluding LaserAttack) currently doesn't give any user-friendly descriptive information (e.g. like the attack_params used) making it difficult to differentiate between attacks without manually inspecting parameters.

Describe the solution you'd like
Printing an attack object will print out attack metadata.
e.g. using __repr__

Describe alternatives you've considered
Currently, users have to explicitly and individually print attack parameters one by one.

Additional context
Useful for scenarios where multiple attacks are being evaluated and would like a quick wait of differentiating between attacks which might be of the same class, but have different attack parameters.

@beat-buesser beat-buesser linked a pull request Sep 7, 2023 that will close this issue
13 tasks
@beat-buesser beat-buesser added improvement Improve implementation enhancement New feature or request labels Sep 7, 2023
@beat-buesser beat-buesser added this to the ART 1.16.0 milestone Sep 7, 2023
@beat-buesser beat-buesser added this to Issues in progress in ART 1.16.0 Sep 12, 2023
@beat-buesser beat-buesser moved this from Issues in progress to Issues closed in ART 1.16.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement Improve implementation
Projects
No open projects
ART 1.16.0
Issues closed
2 participants