feat: point the integs at a remote trustification server #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Crossley <jim@crossleys.org>
Better to see either sbom, vex, or spog in the names, I think Signed-off-by: Jim Crossley <jim@crossleys.org>
Fixes trustification#401 Setting the TRUST_URL env var to a remote trustification server triggers the integs to be run against it. If it's set, other env vars will be required: TRUST_USER_ID -- the client id of the user TRUST_MANAGER_ID -- the client id of the manager TRUST_SECRET -- the secret is assumed to be the same for user & mgr If KAFKA_BOOTSTRAP_SERVERS is set, its value will be used to configure the event bus. Otherwise, SQS is assumed and valid AWS credentials will be required. Signed-off-by: Jim Crossley <jim@crossleys.org>
|
🚀 Deployed Preview: https://trustification-spog-pr-424-preview.surge.sh ✨ |
mrrajan
reviewed
Aug 23, 2023
| impl Config { | ||
| pub async fn new() -> Self { | ||
| let _ = env_logger::try_init(); | ||
| match std::env::var("TRUST_URL") { |
There was a problem hiding this comment.
@jcrossley3 This env variable is configured on .env or local?
There was a problem hiding this comment.
The .env file is only used by the compose scripts. TRUST_URL needs to be set before running the integs with cargo, e.g.
TRUST_URL=http://localhost:8084 cargo test -p integration-tests
There was a problem hiding this comment.
Thanks for the information
ctron
approved these changes
Aug 23, 2023
jcrossley3
added a commit
to jcrossley3/trustification
that referenced
this pull request
Aug 23, 2023
ref trustification#401 & trustification#424 Signed-off-by: Jim Crossley <jim@crossleys.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401
Setting the
TRUST_URLenv var to a remote trustification server triggers the integs to be run against it.If it's set, other env vars will be required:
TRUST_USER_ID-- the client id of the userTRUST_MANAGER_ID-- the client id of the managerTRUST_SECRET-- the secret is assumed to be the same for user & mgrIf
KAFKA_BOOTSTRAP_SERVERSis set, its value will be used to configure the event bus. Otherwise, SQS is assumed and valid AWS credentials will be required.