Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Add custom handler to add inline feature flags #11

Merged
merged 2 commits into from Oct 13, 2014

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Oct 12, 2014

The changesets introduce custom handler for inline feature flags.

One notable difference is, instead of specifying feature flags in dict-style:

FEATURE_FLAGS = {
    "finished": False,
}

the flag must be written in uppercased plain string with FEATURE_FLAGS_X where X is the feature name:

FEATURE_FLAGS_FINISHED = False

The motivation behind this custom handler is to interopt with other Flask extensions, e.g. Flask-AppConfig.

catermelon pushed a commit that referenced this pull request Oct 13, 2014
Add custom handler to add inline feature flags
@catermelon catermelon merged commit dcaeb81 into rachelsanders:master Oct 13, 2014
@catermelon
Copy link
Collaborator

Awesome, thank you so much for the contribution. Did you have anything else you wanted to add? Otherwise I'll release a new version today or tomorrow.

@iromli
Copy link
Contributor Author

iromli commented Oct 13, 2014

Nothing at the moment. Thanks @trustrachel

@iromli iromli deleted the inline-featureflags branch October 13, 2014 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants