This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Raise NoFeatureFlagFound instead of handle missing flags #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger the missing feature behaviour only if the feature wasn't found in any handler.
catermelon
pushed a commit
that referenced
this pull request
Jul 31, 2014
Raise NoFeatureFlagFound instead of handle missing flags
|
I think the name is just fine - it's clear to me. Thanks so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler is not responsible to handle the feature flag missing. I expect the
KeyErroronly if it was not found in any handler.The current implementation works for only one handler.
This is my first step to create a custom handler. I want to make the core responsible for missing keys.
I'm not sure about the exception name. Django use
DoesNotExist, SQLAlchemy useNoResultFound, but I triedFeatureFlagNotFound,NotFound,FeatureNotFoundand others.