This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
NTLMv2 Support #21
Closed
NTLMv2 Support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e improvements. This will ultimately break a lot of the things in the build which will be gradualy fixed once they are found. Bumping version to 2.0.0 as there are some changes that will potentially break other packages using this. Please see CHANGES.md for more details on what has changed
…d on the Microsoft documentation. Added the ability to specify the client challenge when initialising compute_response for testing purposes
… list of features I wish to add in future version. Added a mocking function so that the tests work outside of the one host and can work on travisci. Added more tests to test out authenticate messages and the various forms of NTML authentication
…. Added support for python 3.5 as it is newer. Finalised the last Microsoft compute example for ntlmv2 and added it as a test so we can properly test it out
Feature/add ntlmv2
added 2 commits
August 8, 2016 04:09
…n a server set with the Strict setting to verify. Have added more tests to cover CBT and ensure we don't get any regressions in the future. Modified the arguments to create_NTLM_AUTHENTICATE_MESSAGE so that ntlm_compatibility and server_certificate_hash are in a kwarg allowing more variables to be added in the future without breaking anything major
… 2.6, 2.7, 3.3, 3.4 and 3.5, should be good for Travis now
…e dump function from target_info.py as it isn't necessary and required. Added tests to cover target_info.py methods as well as some more lines in compute_response.py
| @@ -17,6 +17,7 @@ | |||
| import socket | |||
There was a problem hiding this comment.
Is this file even needed in the main section, shouldn't it be in test for our testing and people use requests-ntlm instead when wanting to use python-ntlm3 in a http sense?
This was referenced Aug 7, 2016
…at have occured and give more info on how to use the library. Moved the message structure out to a separate class to make them easier to use in different methods. Brought back the original ntlm methods for compatibility purposes but will be deprecated as they only support NTLMv1 Authentication. Added more tests and added testing to Python 3.5 in appveyor.
… test to cover NTLMv2 computation when the target info isn't supplied from the server
Refactoring
…nd. Also added preliminary support for signing and sealing of messages. Updated the expectations for the tests so that the messages themselves are being checks against the Microsoft examples. Added cryptography as a dependecy due to the need for having RC4 support (looking at removing this at some point if possible). Updated the CHANGES.md and README.md to incorporate the new changes added
…working due to cryptograpy
…he MIC was 0. Fixed up some tests to work with python 3
…pdated the example script to show those methods are deprecated and should be avoided
…ond value being larger than the first instead
…ively. Added tests to test out the rc4 code to ensure it is valid. Fixed up the various uses of cryptography to use the rc4.py file instead
…ng the type first, is there a better way for this?
…g authenticate message (didn't have a 0 byte MIC structure). Updated the expected result outside Microsoft example and tested with an actual server to verify everything is correct.
… put the code back to usual.
Add sign seal
… in automated tests for appveyor. This will test out the actual NTLM calculations and structuring with a real server validating the NTLM auth. This will only run in appveyor and not travis-ci as it is reliant on a windows server. Still better than nothing though.
…list in appveyor.yml
…ing as well as the new integration tests with ntlm.
Iis integration tests
|
No response after 22 days. Created a new repo with these changes here https://github.com/jborean93/ntlm-auth as this project seems to be abandoned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping version to 2.0.0 due to the extensive changes that needed to be made to support NTLMv2 authentication. Contains updates to the computational side so that it supports the wide range of different protocols as well as the theorecticaly potential to use Channel Binding Tokens in the future (still needs some more work in the future). Re-worked the tests to make sure we the computational hashes match up with the Microsoft documentation.