Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make peerId to use UUID version 4 #33

Open
truvorskameikin opened this issue Jun 22, 2021 · 0 comments
Open

Make peerId to use UUID version 4 #33

truvorskameikin opened this issue Jun 22, 2021 · 0 comments
Assignees
Milestone

Comments

@truvorskameikin
Copy link
Owner

Now we use uint32_t as the peerId.

Also we use very strange logic to filter and compare discovered peers (see Same method at https://github.com/truvorskameikin/udp-discovery-cpp/blob/master/udp_discovery_peer.hpp#L87) - it uses peer address and maybe peer port. But if we implement sending packets to all the interfaces then this logic will just break showing multiple peers that are just single peer. Let's remove this comparison but rely on comparing peerIds.

This change will require protocol update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants