Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pressing enter in number / string input it should confirm the prop change #101

Closed
itsdouges opened this issue Jul 1, 2023 · 8 comments
Labels
New feature New feature or request

Comments

@itsdouges
Copy link
Collaborator

itsdouges commented Jul 1, 2023

There's a few ways we could implement this. Wrap them in a form. Listen to the enter keydown even. We should investigate see what feels right, and then do a first pass. Note that we'll want to do some input validation in the future so it might make sense for each prop to be wrapped in a form...!

@itsdouges itsdouges added New feature New feature or request Good first issue labels Jul 1, 2023
@bennett1412
Copy link

Hi, I would like to work on this if possible but I am struggling a bit to get the project running..

@itsdouges
Copy link
Collaborator Author

Let me have a look at the current setup and write a CONTRIBUTING.md file for you 😄

@bennett1412
Copy link

thank you!

@itsdouges
Copy link
Collaborator Author

itsdouges commented Oct 8, 2023

@bennett1412 this is now ready, check out the new CONTRIBUTING.md file

@bennett1412
Copy link

bennett1412 commented Oct 12, 2023

Hi,
I tried following the instructions and ran into this error

yarn run v1.22.19
$ node ./scripts/dev.js room
node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: spawn npx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [ 'triplex', 'editor' ]
}

Node.js v18.17.1

Edit:
Wanted to update, this only happened to me in windows. I tried following the instructions in WSL and it worked. I will try to fix the issue using WSL.

@bennett1412
Copy link

Hey, just noticed that you've removed the good first issue label. Are you still taking contributions?

@itsdouges
Copy link
Collaborator Author

Hey mate, I'm doing some restructuring to the repo so most of the packages aren't OSS anymore. Some of them will come back in the future such as specific UI components, websocket layer, and so on. Sorry for the inconvenience, appreciate the time you've taken so far 🙏.

@bennett1412
Copy link

Ahh, all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants