-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When pressing enter in number / string input it should confirm the prop change #101
Comments
Hi, I would like to work on this if possible but I am struggling a bit to get the project running.. |
Let me have a look at the current setup and write a CONTRIBUTING.md file for you 😄 |
thank you! |
@bennett1412 this is now ready, check out the new CONTRIBUTING.md file |
Hi,
Edit: |
Hey, just noticed that you've removed the good first issue label. Are you still taking contributions? |
Hey mate, I'm doing some restructuring to the repo so most of the packages aren't OSS anymore. Some of them will come back in the future such as specific UI components, websocket layer, and so on. Sorry for the inconvenience, appreciate the time you've taken so far 🙏. |
Ahh, all good 👍 |
There's a few ways we could implement this. Wrap them in a form. Listen to the enter keydown even. We should investigate see what feels right, and then do a first pass. Note that we'll want to do some input validation in the future so it might make sense for each prop to be wrapped in a form...!
The text was updated successfully, but these errors were encountered: