feat: VIT-2418 integrate read data #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anders Ha <anders@tryvital.io>
andersio
reviewed
Jan 31, 2023
| endDate.millisecondsSinceEpoch | ||
| ]); | ||
|
|
||
| return _mapJsonToProcessedData(resource, jsonDecode(result)); |
There was a problem hiding this comment.
Note: #30 now propagates Swift errors by encoding them as ErrorResult and returning them via the channel.
But we haven't yet been handling/expecting ErrorResult on most of the channel consumer on the Dart side, except ask.
There was a problem hiding this comment.
Indeed, I will create a separate ticket for that. https://linear.app/try-vital/issue/VIT-2430/handle-errorresults-in-flutter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.