Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline for implementation of X-B3-Flags and X-B3-Sampled #29

Open
suryatech opened this issue Apr 29, 2015 · 3 comments
Open

Timeline for implementation of X-B3-Flags and X-B3-Sampled #29

suryatech opened this issue Apr 29, 2015 · 3 comments

Comments

@suryatech
Copy link
Contributor

Is the implementation on the cards or do you guys need help with this ?

I see that currently there is no sampleRate construct that is being offered. This would be really helpful when tracing libraries like finagle are used in different services in a given architecture.
@cyli
Copy link
Contributor

cyli commented Apr 30, 2015

Hi @suryatech! Help would very much be appreciated! Thank you for suggesting this and offering to implement it!

@suryatech
Copy link
Contributor Author

@cyli @wadey

I am about to start on this. Any thoughts on how to implement this, at a higher level ?

@drpacman
Copy link
Contributor

I have made a pull request for support of the sampled header (pull #41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyli @drpacman @suryatech