-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings naming #12
Comments
If you like.. can get David to update his PR and I've not made the changes Ghost-side yet. |
can we hold till tomorrow? (or update again tomorrow) - don't have a spare sec atm to go over |
just let know when and what you want it to changed to... this i think i can handle lol |
@ErisDS Right - tell me more about this "type" thing? |
So far settings have been key-value pairs. This is great but you end up with one big blob of stuff, and not all the settings are related. So, title, description, logo etc, all that would get a type of "blog" |
To clarify my understanding - 2 examples would be...
|
Something like that yep |
That's fine with me - so what do you want to do with this issue? |
Updated & assigned. |
so is this issue still open or you want to add the blog and core naming system, is there going to be a new type field ? |
It requires/ is waiting on TryGhost/Ghost#172 |
Closes #12 * master: (27 commits) Upgrading Casper to 1.2.6 Move jQuery before `{{ghost_foot}}` Upgrading Casper to 1.2.5 Add jQuery, as this is being removed from Ghost Added missing vendor prefixes Added box-sizing for a read next story link Updated the twitter web share API Upgrading Casper to 1.2.4 typo Improve alt tag accessibility Upgrading Casper to 1.2.3 Remove border from menu button on small screens Upgrading Casper to 1.2.2 No. Fix footnotes line-height and return-link styling Upgrading Casper to 1.2.1 Social media icons with brand colors on hover Fix copyright footer bug Add version number to icon font src urls Set min width on next-posts ...
fixes TryGhost#12 - added background color to the mobile menu actions - disabled root scrolling when the mobile menu is opened which fixes the duplicate scrolling issue
Related to #11
I actually meant to raise a naming issue about this - potentially better as "blog" rather than "settings" ? as in blog.title or blog.logo or blog.globalthingrelatingtotheblog
Rename "settings" to "blog". We may have other types of setting exposed to the frontend soon.
The text was updated successfully, but these errors were encountered: