Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings naming #12

Closed
JohnONolan opened this issue Jun 16, 2013 · 11 comments
Closed

Settings naming #12

JohnONolan opened this issue Jun 16, 2013 · 11 comments
Assignees
Milestone

Comments

@JohnONolan
Copy link
Member

Related to #11

I actually meant to raise a naming issue about this - potentially better as "blog" rather than "settings" ? as in blog.title or blog.logo or blog.globalthingrelatingtotheblog

Rename "settings" to "blog". We may have other types of setting exposed to the frontend soon.

@ErisDS
Copy link
Member

ErisDS commented Jun 16, 2013

If you like.. can get David to update his PR and I've not made the changes Ghost-side yet.
The only thing to keep in mind is that for the moment, it basically contains any and all settings from the settings table, although I intend to set a type.. which could be "blog" and then only provide settings of type blog to the theme.

@JohnONolan
Copy link
Member Author

can we hold till tomorrow? (or update again tomorrow) - don't have a spare sec atm to go over

@cobbspur
Copy link
Member

just let know when and what you want it to changed to... this i think i can handle lol

@JohnONolan
Copy link
Member Author

@ErisDS Right - tell me more about this "type" thing?

@ErisDS
Copy link
Member

ErisDS commented Jun 17, 2013

So far settings have been key-value pairs. This is great but you end up with one big blob of stuff, and not all the settings are related.
I wanted to introduce a type field, so all settings are key-value grouped by type. It's a little more fiddly in some ways, but I think more powerful in others.

So, title, description, logo etc, all that would get a type of "blog"
Version, and other app fundamentals get a type of "core"
Stuff to do with plugins and themes might be "external" (this is not settings set by 3rd party plugins - thinking of having a separate table entirely for these)

@JohnONolan
Copy link
Member Author

To clarify my understanding - 2 examples would be...

{blog.title} and {core.version} - right?

@ErisDS
Copy link
Member

ErisDS commented Jun 17, 2013

Something like that yep

@JohnONolan
Copy link
Member Author

That's fine with me - so what do you want to do with this issue?

@ghost ghost assigned cobbspur Jun 17, 2013
@ErisDS
Copy link
Member

ErisDS commented Jun 17, 2013

Updated & assigned.

@cobbspur
Copy link
Member

so is this issue still open or you want to add the blog and core naming system, is there going to be a new type field ?

@ErisDS
Copy link
Member

ErisDS commented Jun 21, 2013

It requires/ is waiting on TryGhost/Ghost#172

@ErisDS ErisDS closed this as completed Sep 17, 2013
novaugust added a commit that referenced this issue Aug 6, 2016
Closes #12

* master: (27 commits)
  Upgrading Casper to 1.2.6
  Move jQuery before `{{ghost_foot}}`
  Upgrading Casper to 1.2.5
  Add jQuery, as this is being removed from Ghost
  Added missing vendor prefixes
  Added box-sizing for a read next story link
  Updated the twitter web share API
  Upgrading Casper to 1.2.4
  typo
  Improve alt tag accessibility
  Upgrading Casper to 1.2.3
  Remove border from menu button on small screens
  Upgrading Casper to 1.2.2
  No.
  Fix footnotes line-height and return-link styling
  Upgrading Casper to 1.2.1
  Social media icons with brand colors on hover
  Fix copyright footer bug
  Add version number to icon font src urls
  Set min width on next-posts
  ...
HADB pushed a commit to HADB/Casper that referenced this issue Jun 30, 2018
HADB pushed a commit to HADB/Casper that referenced this issue Dec 24, 2018
yqrashawn pushed a commit to scroll-tech/Casper that referenced this issue Jan 26, 2024
fixes TryGhost#12

- added background color to the mobile menu actions
- disabled root scrolling when the mobile menu is opened which fixes the duplicate scrolling issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants