Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tag.hbs" and "package.json" #83

Closed
kezzbracey opened this issue Mar 3, 2014 · 6 comments
Closed

Add "tag.hbs" and "package.json" #83

kezzbracey opened this issue Mar 3, 2014 · 6 comments

Comments

@kezzbracey
Copy link
Contributor

I thought it might be helpful if I add in a "tag.hbs" file and a "package.json".

I've just styled the tag archive page to look much like the single post page.

I've also set the version number to 0.2.0 but I'm not sure if that's correct?

Will submit a pull request shortly.

@ErisDS
Copy link
Member

ErisDS commented Mar 3, 2014

Casper's current version number is 0.9.2 so that's what package.json should reflect

@JohnONolan
Copy link
Member

@ErisDS Have we even defined what a theme package.json should look like yet though?

@kezzbracey
Copy link
Contributor Author

Didn't mean to jump the gun on that, I just guessed it would be like any other package, gave it a whirl and the admin area picked up the theme name and version number in the dropdown.

No need to include it if we're not ready for that though.

@ErisDS
Copy link
Member

ErisDS commented Mar 3, 2014

@JohnONolan no official docs yet, but what @Polygonix has done is correct according to the implementation we have so far.

@JohnONolan
Copy link
Member

Cool - I'm fine with that. Should be its own PR though

@kezzbracey
Copy link
Contributor Author

Okey dokey, do you want to kill this one then and I'll (attempt to) put the package.json PR through properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants