Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to use the ora module once node 0.12 has reached end-of-life #11

Closed
acburdine opened this issue Aug 15, 2016 · 1 comment
Closed

Upgrade to use the ora module once node 0.12 has reached end-of-life #11

acburdine opened this issue Aug 15, 2016 · 1 comment
Labels
Node LTS
Milestone
1.0.0-alpha.10

Comments

@acburdine
Copy link
Member

Currently there is a re-implemented/copied version of the ora package sitting inside of the CLI.

The reasoning behind this is that the ora module does not support any node version < 4. Because we need to support node 0.10 and 0.12 until they have reached end of life, the library needed to be re-implemented in a backwards-compatible way.

Once support for Node 0.12 is dropped in December (see the node lts schedule) this reimplementation can be swapped out for the actual package.
@acburdine acburdine added this to the Node 0.12 EOL milestone Aug 15, 2016
@acburdine acburdine changed the title Upgrade to use the ora module once node 0.12 has reached end-of-supported. Upgrade to use the ora module once node 0.12 has reached end-of-life. Aug 15, 2016
@acburdine acburdine changed the title Upgrade to use the ora module once node 0.12 has reached end-of-life. Upgrade to use the ora module once node 0.12 has reached end-of-life Aug 15, 2016
@acburdine
Copy link
Member Author

Update: As Node v0.12 is slated to be dropped in a week, this will come before the next CLI release.

@acburdine acburdine mentioned this issue Dec 25, 2016
Closed
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jan 8, 2017
@acburdine
🔥 replace spinner class with ora npm module
3733b3f 
closes TryGhost#11
- remove cli-cursor, cli-spinners, and log-symbol dips
- deps: ora@0.4.0
- fix eslintrc to allow for es6 features
@acburdine acburdine mentioned this issue Jan 8, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Node LTS
Projects
None yet
Milestone
1.0.0-alpha.10
Development

No branches or pull requests
1 participant
@acburdine