Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current directory is not empty, Ghost cannot be installed here #173

Closed
2 tasks
kirrg001 opened this issue Mar 16, 2017 · 2 comments
Closed
2 tasks

Current directory is not empty, Ghost cannot be installed here #173

kirrg001 opened this issue Mar 16, 2017 · 2 comments
Assignees

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Mar 16, 2017

Could we optimise the validation for this error?

Here is the following case:
I run ghost install help and it fails because help is not available. There are for sure other command combinations users uses.

Then i run ghost install and it tells me that Current directory is not empty, Ghost cannot be installed here.. This is quite annoying, because the only file which was created is ghost-cli-debug-2017-03-16T10.log. And as none Ghost developer i might not know what todo.

Possible tasks:

  • improve messaging
  • improve "Ghost cannot be installed here" validation
@dandv
Copy link

dandv commented Mar 8, 2018

I still get this error incorrectly. It was triggered by entering the wrong password due to an arguably confusing prompt:

image

After that, the installation seems to be in a broken state. I've deleted /var/www/ghost, but running ghost install produces "Message: Current directory is not empty, Ghost cannot be installed here.". Deleted /var/www/ - no improvement.

@ErisDS
Copy link
Member

ErisDS commented Mar 12, 2018

@dandv I have questions:

triggered by entering the wrong password due to an arguably confusing prompt

What was confusing here? What were your expectations?

After that, the installation seems to be in a broken state.

Did you try to use ghost uninstall ?

I've deleted /var/www/ghost, but running ghost install produces "Message: Current directory is not empty, Ghost cannot be installed here.". Deleted /var/www/ - no improvement.

After deleting folders, where did you try to install Ghost?

I understand that you expect that the CLI would clean up after itself, that's very tricky though - imagine if you ran ghost install in an already setup ghost folder by mistake, it failed, and Ghost deleted everything... it's better for us to err on the side of caution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants