Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Validation #26

Closed
kirrg001 opened this issue Sep 12, 2016 · 1 comment · Fixed by #171
Closed

Config Validation #26

kirrg001 opened this issue Sep 12, 2016 · 1 comment · Fixed by #171
Labels
enhancement

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Sep 12, 2016 •
edited

As discussed:

We want to outsource validating a config file from Ghost. Another thing we can outsource is checking for deprecated config values.

See https://github.com/TryGhost/Ghost/blob/lts/core/server/config/index.js#L406
See https://github.com/TryGhost/Ghost/blob/lts/core/server/config/index.js#L487

See TryGhost/Ghost#7488 (comment)
@kirrg001
Copy link
Contributor Author

kirrg001 commented Sep 13, 2016 •
edited

https://github.com/TryGhost/Ghost/blob/lts/core/server/utils/startup-check.js

Also these checks belong to the Ghost-CLI.

@acburdine acburdine changed the title validate config and check for deprecated config values Config Validation Sep 30, 2016
@acburdine acburdine mentioned this issue Sep 30, 2016
Closed
18 tasks
@acburdine acburdine modified the milestone: 1.0.0-alpha.5 Oct 19, 2016
@acburdine acburdine added this to the 1.0.0-alpha.11 milestone Jan 28, 2017
@kirrg001 kirrg001 mentioned this issue Jan 30, 2017
Closed
12 tasks
@acburdine acburdine mentioned this issue Feb 14, 2017
Closed
1 task
@acburdine acburdine removed this from the 1.0.0-alpha.11 milestone Feb 19, 2017
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 15, 2017
@acburdine
feat(startup): validate config on startup
afe4a78 
closes TryGhost#26
- add `startup` checks to ghost-cli
@acburdine acburdine mentioned this issue Mar 15, 2017
Merged
acburdine added a commit that referenced this issue Mar 15, 2017
@acburdine
feat(startup): validate config on startup
1f9383f 
closes #26
- add `startup` checks to ghost-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(startup): validate config on startup acburdine/Ghost-CLI
2 participants
@kirrg001 @acburdine