Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ghost-CLI Process Management #66

Closed
acburdine opened this issue Oct 19, 2016 · 1 comment · Fixed by #81
Closed

Refactor Ghost-CLI Process Management #66

acburdine opened this issue Oct 19, 2016 · 1 comment · Fixed by #81
Assignees
Milestone

Comments

@acburdine
Copy link
Member

Current Approach

At the moment, Ghost-CLI process management is a bit hands-off in its approach. Essentially, Ghost-CLI intends to start the ghost process (be it through a detached child process, pm2 process manager, systemd, forever, etc) and then exit, leaving only the one running Ghost process.

However, there are several features needed to make the CLI work well (#61 and #65 are the current open ones), and the current method of starting Ghost does not effectively support them. Better put, to effectively support these features, there would have to be an incredibly strict control over the process manager, making it difficult for third-party process managers (using things like upstart or pm2 or forever) to run Ghost whilst providing the information the CLI needs to run correctly.

A New Approach

The new approach that should solve most of these issues is to tightly integrate the Ghost process with a CLI command. This proposed CLI command (working name: ghost run) would run the Ghost server in a forked child process, and any process manager would start ghost run instead of starting Ghost itself.

@acburdine acburdine added this to the 1.0.0-alpha.5 milestone Oct 19, 2016
@acburdine acburdine self-assigned this Oct 19, 2016
@acburdine
Copy link
Member Author

Will close this once Ghost has been updated to use inter-process communication.

@acburdine acburdine removed this from the 1.0.0-alpha.5 milestone Oct 25, 2016
@acburdine acburdine added this to the 1.0.0-alpha.7 milestone Nov 1, 2016
acburdine added a commit that referenced this issue Nov 6, 2016
closes #66,#61
- breaking: won't work with any ghost versions < 1.0.0-alpha.8
acburdine added a commit that referenced this issue Nov 7, 2016
closes #66,#61
- breaking: won't work with any ghost versions < 1.0.0-alpha.8
acburdine added a commit that referenced this issue Nov 7, 2016
closes #66,#61
- breaking: won't work with any ghost versions < 1.0.0-alpha.8
acburdine added a commit that referenced this issue Nov 8, 2016
closes #66,#61
- breaking: won't work with any ghost versions < 1.0.0-alpha.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant