Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Members SDK Layer 1 #8

Closed
allouis opened this issue Nov 8, 2018 · 3 comments · Fixed by #10
Closed

Create Members SDK Layer 1 #8

allouis opened this issue Nov 8, 2018 · 3 comments · Fixed by #10
Assignees
Labels
members Required for completion of members

Comments

@allouis
Copy link
Contributor

allouis commented Nov 8, 2018

Create the initial members sdk - this will be a fairly low level one.

The api it should expose will be like

const Members = require('@ghost/members-sdk');

const members = Members(options); // options can be undefined, for now...

// returns Promise.resolve(token|null) if they are logged in or not
members.getToken();

// returns Promise.resolve(true|false) on whether it worked or not
members.logout();

// returns Promise.resolve(true|false) on whether it worked or not
members.login();

thoughts?

@allouis allouis added the members Required for completion of members label Nov 8, 2018
@allouis
Copy link
Contributor Author

allouis commented Nov 8, 2018

@rishabhgrg @JohnONolan what you think of this?

@rishabhgrg
Copy link
Contributor

I think we need this too right?

// returns Promise.resolve(true|false) on whether it worked or not
members.startSession();

@allouis
Copy link
Contributor Author

allouis commented Nov 8, 2018

Yeah good point @rishabhgrg updated - wdyt?

@allouis allouis changed the title Create Members SDK Create Members SDK Layer 1 Nov 8, 2018
rishabhgrg added a commit to rishabhgrg/Ghost-SDK that referenced this issue Nov 8, 2018
rishabhgrg added a commit to rishabhgrg/Ghost-SDK that referenced this issue Nov 8, 2018
rishabhgrg added a commit to rishabhgrg/Ghost-SDK that referenced this issue Nov 9, 2018
rishabhgrg added a commit that referenced this issue Nov 9, 2018
naz pushed a commit to naz/Ghost-SDK that referenced this issue Sep 24, 2020
naz pushed a commit to naz/Ghost-SDK that referenced this issue Sep 28, 2020
naz pushed a commit to naz/Ghost-SDK that referenced this issue Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
members Required for completion of members
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants