Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should round up the value of the typography scale values in variables by using ceil #45

Closed
ashleynolan opened this issue Mar 18, 2015 · 4 comments
Assignees

Comments

@ashleynolan
Copy link
Contributor

The values produced by the modular scale for type should be rounded up so that the pixel equivalents are whole numbers, rather than to 3 or 4 dp as some of them are calculated. Makes the compiled CSS much more standard.

https://github.com/tmwagency/kickoff/blob/master/scss/_variables.scss#L30

@mrmartineau
Copy link
Member

I have never found this to be an issue before but I think it is a good idea. The font-sizes are generated using our modular scale function so we'd just need to tweak that to get the desired output.

I think we'd just need to change this line from:

@return $value;

to

@return ceil($value);

See SassScript docs: http://sass-lang.com/documentation/Sass/Script/Functions.html#ceil-instance_method

@mrmartineau
Copy link
Member

@ashleynolan I tried a quick test for this, see it at http://quick.as/vmr4cq8yw & let me know if you think it is acceptable.

@ashleynolan
Copy link
Contributor Author

Looks good to me :)

@ashleynolan
Copy link
Contributor Author

Closing as fixed from previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants