Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup environment file for Windows #148

Closed
Fryingpannn opened this issue Jun 26, 2024 · 1 comment · Fixed by #151
Closed

Fix setup environment file for Windows #148

Fryingpannn opened this issue Jun 26, 2024 · 1 comment · Fixed by #151
Labels
DevX Good First Issue Good for newcomers

Comments

@Fryingpannn
Copy link
Contributor

Context

[Bug found by Himanshu]

Currently, windows setup is buggy due to mainly two reasons: symlinks and git submodule. We have discovered a major reason why extension doesn't show up on Windows is due to symlink not working properly. The Pear extension folder is nested within the pearai-submodule folder, thus we need a symlink from the outer extensions folder that references it directly in order for Pear to actually discover the Pear extension. If this symlink doesn't work, Pear will not pop up.

Solution

Update setup-environment.ps1 - delete already existing symlink before creating new ones. Because if the folder is already created, the symlink may fail.

Also would be nice if some way to prevent the setup-environment.sh file from being ran if user is using Windows since that script is for Mac. This can prevent some unexpected errors from accidentally running the Mac script instead of the Windows.

Himanshu:
"my symlink folder somehow got converted to actual folder, don't know how, maybe i ran .sh setup script, thats why, so its better to ensure we remove the already existing symlink and then create new link."

@Himanshu-Singh-Chauhan
Copy link
Contributor

I'll take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevX Good First Issue Good for newcomers
Projects
None yet
3 participants