Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrar should return event response with error in case registrar address is not exisiting/offline etc #110

Closed
vinkabuki opened this issue Sep 7, 2021 · 7 comments
Projects

Comments

@vinkabuki
Copy link
Collaborator

No description provided.

@holmesworcester
Copy link
Contributor

The ultimate behavior we want here is for the client to remain in a "trying to join" state, even across restarts, and keep retrying periodically at whatever interval makes sense, whenever it is running. Does that make sense?

Should we implement this behavior now, or just throw an error at this stage?

It seems like we should have a separate ticket for friendly retry behavior when the registrar is not online.

@vinkabuki
Copy link
Collaborator Author

I think we should return an errors to the frontend atm, because we don't yet know how we will handle the problem with different ports: eg. It must be either the same port always, which can't be guaranteed, also, if owner has 20 communities that means 20 registrars on 20 different ports. I think we shuuld discuss about this topic on the next tuesday

@vinkabuki
Copy link
Collaborator Author

At this moment we attempt to connect to hardcoded port - so the owner must take care, that registrar started on the given port

@vinkabuki
Copy link
Collaborator Author

We can also attach port to onion address we are sharing, but I don't know about security issues and also it doesn't guarantee anything too, because next time other app will be occuping this port

@vinkabuki
Copy link
Collaborator Author

I have this in mind, using libp2p would solve this, because port doesn't in multiaddress, if I am not wrong, but I remember I was trying to make libp2p stop working by changing port and it didn't help, it connected to other peers.

@holmesworcester
Copy link
Contributor

holmesworcester commented Sep 8, 2021 via email

@holmesworcester
Copy link
Contributor

@vinkabuki

  1. is the ports thing still an issue?
  2. is this ticket a duplicate of Nectar/waggle should try to call registrar a few times before giving up nectar#10 ?

@vinkabuki vinkabuki transferred this issue from TryQuiet/waggle Jan 4, 2022
siepra added a commit that referenced this issue Feb 9, 2022
…ive-builds

Feature/link versioning with native builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Quiet
Backlog - Desktop & Backend
Development

No branches or pull requests

2 participants