-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registrar should return event response with error in case registrar address is not exisiting/offline etc #110
Comments
The ultimate behavior we want here is for the client to remain in a "trying to join" state, even across restarts, and keep retrying periodically at whatever interval makes sense, whenever it is running. Does that make sense? Should we implement this behavior now, or just throw an error at this stage? It seems like we should have a separate ticket for friendly retry behavior when the registrar is not online. |
I think we should return an errors to the frontend atm, because we don't yet know how we will handle the problem with different ports: eg. It must be either the same port always, which can't be guaranteed, also, if owner has 20 communities that means 20 registrars on 20 different ports. I think we shuuld discuss about this topic on the next tuesday |
At this moment we attempt to connect to hardcoded port - so the owner must take care, that registrar started on the given port |
We can also attach port to onion address we are sharing, but I don't know about security issues and also it doesn't guarantee anything too, because next time other app will be occuping this port |
I have this in mind, using libp2p would solve this, because port doesn't in multiaddress, if I am not wrong, but I remember I was trying to make libp2p stop working by changing port and it didn't help, it connected to other peers. |
is this relevant?
https://riseup.net/en/security/network-security/tor/onionservices-best-practices#multiple-ports-for-one-onion-service
we can change the mapping between internal and external ports whenever we
want to. but i think it makes sense to use a separate onion service for the
registrar, so that having access to the registrar does not reveal a peer
address, and so that the registrar address can be expired.
…On Wed, Sep 8, 2021 at 10:33 AM vinkabuki ***@***.***> wrote:
I have this in mind, using libp2p would solve this, because port doesn't
in multiaddress
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/ZbayApp/waggle/issues/101#issuecomment-915292874>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUFLR4ECZFBQVUELCDKLLUA5X2LANCNFSM5DSMN3BQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
…ive-builds Feature/link versioning with native builds
No description provided.
The text was updated successfully, but these errors were encountered: