Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload/download tracker bugfixes #184

Merged
merged 6 commits into from Jun 15, 2022
Merged

Conversation

bcai2
Copy link
Contributor

@bcai2 bcai2 commented Jun 15, 2022

  • Refactors the tracking printed statements into a pythonic print call with string formatting.
  • Fixes status update logic in uploading. (This was causing the terminal output to stall at the "uploading" stage.)
  • Adds integration test dirs to .gitignore.

@bcai2 bcai2 requested review from jherr-dev and lebovic June 15, 2022 17:58
Copy link
Member

@lebovic lebovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the implicit \n in print is still present, the output I see is:

Uploading ./synthetic_bacteroides_reads.fasta
synthetic_bacteroides_reads.fasta  262144 / 1883273.0 bytes (13.92%)                               
synthetic_bacteroides_reads.fasta  524288 / 1883273.0 bytes (27.84%)                               
synthetic_bacteroides_reads.fasta  786432 / 1883273.0 bytes (41.76%)                               
synthetic_bacteroides_reads.fasta  1048576 / 1883273.0 bytes (55.68%)                              
synthetic_bacteroides_reads.fasta  1310720 / 1883273.0 bytes (69.60%)                              
synthetic_bacteroides_reads.fasta  1572864 / 1883273.0 bytes (83.52%)                              
synthetic_bacteroides_reads.fasta  1835008 / 1883273.0 bytes (97.44%)                              
synthetic_bacteroides_reads.fasta  1883273 / 1883273.0 bytes (100.00%)                             

Finished spawning jobs.

Rather than replacing the same line

@bcai2
Copy link
Contributor Author

bcai2 commented Jun 15, 2022

Good catch! Should be fixed on the latest commit, give it a try

It looks like the implicit \n in print is still present, the output I see is:

Uploading ./synthetic_bacteroides_reads.fasta
synthetic_bacteroides_reads.fasta  262144 / 1883273.0 bytes (13.92%)                               
synthetic_bacteroides_reads.fasta  524288 / 1883273.0 bytes (27.84%)                               
synthetic_bacteroides_reads.fasta  786432 / 1883273.0 bytes (41.76%)                               
synthetic_bacteroides_reads.fasta  1048576 / 1883273.0 bytes (55.68%)                              
synthetic_bacteroides_reads.fasta  1310720 / 1883273.0 bytes (69.60%)                              
synthetic_bacteroides_reads.fasta  1572864 / 1883273.0 bytes (83.52%)                              
synthetic_bacteroides_reads.fasta  1835008 / 1883273.0 bytes (97.44%)                              
synthetic_bacteroides_reads.fasta  1883273 / 1883273.0 bytes (100.00%)                             

Finished spawning jobs.

Rather than replacing the same line

@bcai2 bcai2 requested a review from lebovic June 15, 2022 18:04
Co-authored-by: Noah Lebovic <security@trytoolchest.com>
Copy link
Member

@lebovic lebovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jherr-dev jherr-dev merged commit b2f17dc into staging Jun 15, 2022
@jherr-dev jherr-dev deleted the fix/double-overwrite-bug branch June 15, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants