Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro benchmarks for comparison functions in C++ SDK #108

Closed
cthulhu-irl opened this issue Jun 5, 2022 · 1 comment
Closed

Add micro benchmarks for comparison functions in C++ SDK #108

cthulhu-irl opened this issue Jun 5, 2022 · 1 comment
Labels
C++ SDK Component: Touca SDK for C++ 💡 Community Inspired Inspired by conversations in touca.io/discord community 💪🏼 Improvement Issues that improve existing features or make maintaining them easier

Comments

@cthulhu-irl
Copy link
Contributor

Touca's cpp-sdk is subject to performance and layout improvements (for example as #107 suggests) and features like supporting blobs as data_point are in discussion.

As performance of changes aren't measured yet, these changes and their impact aren't quite comparable, thus there is a need of adding benchmarking.

@ghorbanzade ghorbanzade changed the title Benchmark C++ SDK Add micro benchmarks for comparison functions in C++ SDK Jun 6, 2022
@ghorbanzade ghorbanzade added 💪🏼 Improvement Issues that improve existing features or make maintaining them easier C++ SDK Component: Touca SDK for C++ 💡 Community Inspired Inspired by conversations in touca.io/discord community labels Jun 6, 2022
@ghorbanzade
Copy link
Member

This issue is no longer relevant. We've removed the standalone Touca Comparator service which was in C++. Touca v1.8 now has a built-in comparison service written in TypeScript. We've also added micro-benchmarks to the implementations to keep an eye on the performance of the new service. Since C++ comparison logic is no longer used in the server, we recently moved it out of the core library and into the C++ CLI executable. We plan to remove that CLI executable in an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ SDK Component: Touca SDK for C++ 💡 Community Inspired Inspired by conversations in touca.io/discord community 💪🏼 Improvement Issues that improve existing features or make maintaining them easier
Projects
Status: Done
Development

No branches or pull requests

2 participants