Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building error of 1.39.1 #56

Closed
trzecieu opened this issue Nov 6, 2019 · 3 comments · Fixed by #57
Closed

Building error of 1.39.1 #56

trzecieu opened this issue Nov 6, 2019 · 3 comments · Fixed by #57

Comments

@trzecieu
Copy link
Owner

trzecieu commented Nov 6, 2019

[5/5](****/emscripten-fastcomp:1.39.1)[19/36][%](Create symbolic links) 
The command '/bin/sh -c echo "## Create symbolic links"     
&&  . ${EMSDK}/emsdk_set_env.sh         
&&  mkdir -p ${EMSDK}/llvm ${EMSDK}/emscripten ${EMSDK}/binaryen        
&&  ln -s $(dirname $(which node))/..       ${EMSDK}/node/current     
&&  ln -s $(dirname $(which clang))/..      ${EMSDK}/llvm/clang     
&&  ln -s $(dirname $(which emcc))          ${EMSDK}/emscripten/sdk     
&&  ln -s $(dirname $(which asm2wasm))      ${EMSDK}/binaryen/bin         
&&  echo "## Done"' returned a non-zero code: 1
@kleisauke
Copy link
Contributor

Commit emscripten-core/emsdk@ae5044e might be relevant here. I'm able to build the trzeci/emscripten-fastcomp:1.39.2 Docker image with this patch:

diff --git a/docker/trzeci/emscripten-fastcomp/Dockerfile b/docker/trzeci/emscripten-fastcomp/Dockerfile
index 1111111..2222222 100644
--- a/docker/trzeci/emscripten-fastcomp/Dockerfile
+++ b/docker/trzeci/emscripten-fastcomp/Dockerfile
@@ -4,7 +4,7 @@ FROM debian:stretch AS stage_build
 
 # ATM 1.38.40+ is supported, older will fail with missing /b/s/w/ir/k/install/fastcomp/bin/llc
 ARG EMSCRIPTEN_VERSION=1.38.43
-ARG EMSCRIPTEN_SDK=${EMSCRIPTEN_VERSION}
+ARG EMSCRIPTEN_SDK=${EMSCRIPTEN_VERSION}-fastcomp
 ARG EMSDK_CHANGESET=master
 
 # ------------------------------------------------------------------------------

Tested on Fedora 31 (using Podman) with:

BUILDAH_FORMAT=docker python3 -m builder compile 1.39.2

@trzecieu
Copy link
Owner Author

Thank you! Can you please create a PR for this?

@kleisauke
Copy link
Contributor

PR #57 resolves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants