Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quad rendering the new default? #19

Closed
toxieainc opened this issue Aug 22, 2022 · 7 comments
Closed

Make quad rendering the new default? #19

toxieainc opened this issue Aug 22, 2022 · 7 comments

Comments

@toxieainc
Copy link
Contributor

As the feature is more precise and roughly same speed (measured on my Intel and NVIDIA laptop GPUs, using HDish resolution and no-throttle and no-vsync), should it be the new default?

@dukeeeey
Copy link
Collaborator

dukeeeey commented Aug 22, 2022

The quad renderer won't work on apple. Also needs a compatibility profile which is also unsupported by apple. No idea how it performs on amd hw

@trzy
Copy link
Owner

trzy commented Aug 31, 2022

We could make it default on Windows and Linux (anything not Apple) with an ifdef. We don’t want too many of those floating around the code base but in this case it’s probably fine.

@toxieainc
Copy link
Contributor Author

I think its a good idea! :)

@dukeeeey
Copy link
Collaborator

dukeeeey commented Nov 2, 2022

I would like this as the default but I think AMD users will cry :p

@dukeeeey dukeeeey closed this as completed Nov 2, 2022
@toxieainc
Copy link
Contributor Author

But why? Do you know of AMD users that complained about the quad rendering performance with the new changes?
Even Intel now is roughly same speed as the tri pipeline.

@dukeeeey
Copy link
Collaborator

dukeeeey commented Nov 2, 2022

I think it's just the geometry shader that helps nuke the performance. Geometry shader is usually fast on intel because it's all done on the cpu. There is no round trip.

@toxieainc
Copy link
Contributor Author

I think that was only true like 5+ years ago. ;) Nowadays rather simple GS should be fast on all platforms, otherwise most common games would just extremely suck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants